Add architecture to model #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should solve #100 |
jappi00
force-pushed
the
add-architecture-to-images
branch
2 times, most recently
from
a78a321 to
9430137
Compare
jappi00
force-pushed
the
add-architecture-to-images
branch
from
9430137 to
edc5b59
Compare
|
Hello @LKaemmerling, Sorry to disturb you, but is this repo actively maintained? I don't ask because of this pr, but many others are for a longer period of time open, and I currently think about use this package for a project. Thank you! |
|
Hey @jappi00, Yes it is maintained on a best effort base. It is quite hard at the moment for me to dedicate a lot of time to this project. I will review it once I'm out of my parental leave (early October). |
|
@jappi00 - We manually patched our local dev environments with your code and as far as we can tell it works. Thanks for the patch - saved us a bunch of time. FYI @LKaemmerling if it helps. |
|
Thank you @jappi00! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.